[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Fix paravirt FB with xm driver



On Fri, Aug 10, 2007 at 05:16:28PM +0100, Richard W.M. Jones wrote:
> Daniel P. Berrange wrote:
> >The code for dealing with the paravirt framebuffer was missing code to deal
> >with an explicit vncdisplay=N  setting - only working for vncunused=1. It
> >was also not flexible enough in processing the 2 different styles of FB
> >config.
> 
> I too am having trouble following the explanation / code.  Can you 
> explain a bit more ...?

Two core issues

For paravirt the framebuffer can be configured in either old style:

   vnc=1
   vncunused=1

Or new style

   vfb = ["type=vnc,vncunused=1"

The problem was that with Xen > 3.0.3 we were only handling the latter
and not the former. We needed to process both styles for compatability.


The second part of it is that while we handled

   <graphics type='vnc' port='-1' />

Converting to 'vncunused=1'.  We did not handle

   <graphics type='vnc' port='5905' />

Which needs to convert to vncunused=0, and vncdisplay=5

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]