[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Block device and network stats



On Fri, Aug 10, 2007 at 03:35:08PM +0100, Richard W.M. Jones wrote:
> This is the implementation (currently Xen, local only).

  Thanks !

> +++ include/libvirt/libvirt.h.in	10 Aug 2007 14:30:21 -0000
> @@ -14,6 +14,9 @@
>  #ifndef __VIR_VIRLIB_H__
>  #define __VIR_VIRLIB_H__
>  
> +#include <sys/types.h>
> +#include <stdint.h>
> +
[...]
> +struct _virDomainBlockStats {
> +  int64_t rd_req;

  That's my only worry at the moment. stdint.h isn't really that portable,
we want to define an 64bits unsigned field, but we already use 
   unsigned long long 
in libvirt.h . I would be tempted to rationalize this, either we think
(stdint.h/int64_t) is more portable or long long is the one, but I would
prefer if we picked one and stick with it at the API level.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]