[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Check the version of Xen in xenDaemonAttachDevice()



On Thu, Aug 16, 2007 at 02:56:07PM +0100, Daniel P. Berrange wrote:
> On Thu, Aug 16, 2007 at 09:27:04AM -0400, Daniel Veillard wrote:
> > On Thu, Aug 16, 2007 at 05:41:47PM +0900, Masayuki Sunou wrote:
> > > Hi
> > > 
> > > When virsh attach-disk/attach-interface is executed in < Xen 3.0.4,
> > > the OS type of domain is NULL in xenDaemonAttachDevice().
> > > As a result, the command becomes segmentation fault.
> > > 
> > > This patch fixes it by checking the version of Xen in xenDaemonAttachDevice().
> > > 
> > > Signed-off-by: Masayuki Sunou <fj1826dm aa jp fujitsu com>
> > [...]
> > >  
> > > +    if (domain->id < 0 && priv->xendConfigVersion < 3)
> > > +        return(-1);
> > > +
> > >      str = virDomainGetOSType(domain);
> > >      if (strcmp(str, "linux"))
> > >          hvm = 1;
> > 
> >   I do not understand the patch. Why is that dependant on domain->id < 0 ?
> > Can you explain the logic there ?
> 
> That just ensures that this command fails in a sensible way with inactive
> guests when run on older XenD without the inactive domain management APIs.

  Oh right, a domain->inactive flag or some such would be so much more 
readable. Applied and commited then !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]