[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Cleanup xs_internal.c



On Tue, Aug 21, 2007 at 09:58:27AM +0900, Atsushi SAKAI wrote:
> Hi, Daniel
> 
> That's a good idea.
> Anyway some code seems to be assumed tab = 8spaces(not 4spaces),
> I hope this kind of mis-spaces will be fixed.

  Well I actually looked at xenStoreOpen() which is one of the places 
your patch changes, and that section looks fine in my editor. Indenting
is using a shift of 4 columns, and the tab aligns to the closest multiple
of 8 (which is the main standard definition for it), the lines you changed
rendered fine for me as they indented to the second level in a function,
i.e. using 4 spaces to align inside the function and a tab to align at 
column 8 in the block inside the test. To me there is no need to patch
it renders just fine. Could you check your editor setting ?

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]