[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Block device and network stats (version 2)



Hello,

- Aren't "xdr_remote_domain_interface_stats_ret" and "xdr_remote_domain_interface_stats_args" functions missing in the patch? As I understand, those should be in qemud/remote_protocol.c. Repesctively, qemud/remote_protocol.h changes are missing too.

Best regards,
Mindaugas Kiznis

Richard W.M. Jones wrote:
This patch adds block device and network stats. The main changes over the previous version are:

* Remote support.
* Change Xen network interface names to have the form "vif<domid>.<n>"[1].

Discussions about the previous version may be found starting here:
https://www.redhat.com/archives/libvir-list/2007-August/thread.html#00064

I have left use of stdint.h / int64_t, since it wasn't clear to me what conclusion people had arrived at.

I left the explicit structure size parameter to allow for future extensibility.

Also attached is the output of:
  virsh -c xen+tls://amd/ domifstat fc6_1 vif2.0

Rich.

[1] There is currently no way to get the interface name except to just know it -- that is the subject of a separate patch.

------------------------------------------------------------------------

--
Libvir-list mailing list
Libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]