[Libvir] [PATCH] Fix endless loop of VirBufferVSprintf()

Daniel Veillard veillard at redhat.com
Thu Aug 30 13:12:52 UTC 2007


On Thu, Aug 30, 2007 at 11:29:34AM +0900, Masayuki Sunou wrote:
> Hi
> 
> Would you give me a comment on this?
> This occurs when virsh create is executed by using the attached file.  

  Yes, sorry when I first looked at the patch I though I needed to
give it a deeper look because I misunderstood something, and I forgot 
about it ... Looking again, yes this is right, the code made an assumption
which was that virBufGrow would automatically allocate at least the
size given while it just ensure that there is at least that space available.
  You patch is right, applied and commited to CVS,

    thanks a lot !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/




More information about the libvir-list mailing list