[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: 10/10: fix Xen driver warnings

On Thu, Nov 29, 2007 at 02:53:05PM -0500, Daniel Veillard wrote:
> On Thu, Nov 29, 2007 at 05:22:39PM +0000, Daniel P. Berrange wrote:
> > If building using  --without-xen to disable the Xen driver there
> > are a whole bunch of methods in the src/xml.c file which are not
> > used. There are littered with #if WITH_XEN to disable small parts
> > of the API, but not the whole APIs. This is pointless and results
> > in many compile time warnings about unused variables. This patch
> > just disables all the Xen specific APIs in xml.c entirely.
> > 
> >  src/xml.c             |   19 +++++--------------
> >  src/xml.h             |    2 ++
> >  tests/xml2sexprtest.c |   10 ++++++++++
> >  3 files changed, 17 insertions(+), 14 deletions(-)
>   Well the side effect is that some of the regression tests can't
> be run then, we discussed that already, but I'm not against the 
> patch, just that it reverses a previous decision,

I don't think we loose any useful test coverage. If you have disabled
the Xen driver, then the Xen test cases are not actually testing any
useful code, since we comment out all the bits which would use Xen.
So the tests merely end up testing something which is a no-op. The
nightly automated tests I have test with all drivers enable in any

So I've committed this now.

|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]