Jim Meyering wrote:
Without this patch, building without HAVE_AVAHI fails due to an unguarded use of mdns_name. Rather than adding yet another #ifdef..#endif (ugly and less maintainable), I've chosen to un-ifdef the declarations and a few uses. The more code that we compile and use unconditionally, the fewer surprises we'll encounter down the road.
Strangely enough I didn't hit this problem when building on Cygwin, and I'm pretty sure they don't have avahi?
My only reservation is what happens if mdns_* configuration is in libvirtd.conf, but there is no support in the binary. Should we print out an error message or a warning?
General principles though +1 Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
Description: S/MIME Cryptographic Signature