[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Remove curses, don't require readline



Daniel Veillard <veillard redhat com> wrote:
> On Tue, Dec 04, 2007 at 05:39:17PM +0000, Richard W.M. Jones wrote:
>> This patch removes checking for curses/ncurses.  It is never used.
>>
>> It also allows libvirt to be compiled without readline support.  If
>> readline support is not available then the only difference is that
>> 'virsh' will be built without it -- in other words, command line editing
>> will not work in virsh.
>
>   Makes sense,
>
> [...]
>> +static char *
>> +vshReadline (vshControl *ctl, const char *prompt)
>> +{
>> +    char line[1024];
>> +    char *r;
>> +    int len;
>> +
>> +    fputs (prompt, stdout);
>> +    r = fgets (line, sizeof line, stdin);
>
>    shouldn't we use parenthesis i.e. sizeof(line)

Either works just fine for variable names and simple expressions.
It's a question of style.
I like to avoid the extra parens, when possible.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]