[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Latest MinGW patch



"Richard W.M. Jones" <rjones redhat com> wrote:
> Index: src/virsh.c
> ===================================================================
> RCS file: /data/cvs/libvirt/src/virsh.c,v
> retrieving revision 1.117
> diff -u -r1.117 virsh.c
...
> @@ -3705,7 +3713,9 @@
>      {"autostart", cmdAutostart, opts_autostart, info_autostart},
>      {"capabilities", cmdCapabilities, NULL, info_capabilities},
>      {"connect", cmdConnect, opts_connect, info_connect},
> +#ifndef __MINGW32__
>      {"console", cmdConsole, opts_console, info_console},
> +#endif /* !__MINGW32__ */
>      {"create", cmdCreate, opts_create, info_create},
>      {"start", cmdStart, opts_start, info_start},
>      {"destroy", cmdDestroy, opts_destroy, info_destroy},

Please don't make the existence of an option depend on #ifdefs.
Then we'd have to adjust the manual and --help output, too.

In this particular case, it'd make --co and --con work (as aliases
for --connect) on mingw, while they don't work anywhere else
due to the ambiguity.

Instead, it'd be nice to handle the option and
give a diagnostic saying it's not supported on mingw.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]