[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Latest MinGW patch



Hi Rich,

This looks good so far.
Here's a suggestion that makes the manual-#ifdef-adding parts of your
patch less numerous:

"Richard W.M. Jones" <rjones redhat com> wrote:
> Index: bootstrap
> ===================================================================
> RCS file: /data/cvs/libvirt/bootstrap,v
> retrieving revision 1.1
> diff -u -r1.1 bootstrap
> --- bootstrap	5 Dec 2007 21:31:07 -0000	1.1
> +++ bootstrap	6 Dec 2007 11:27:48 -0000
...
> -  --import physmem getaddrinfo
> +  --import physmem getaddrinfo  \
> +    sys_stat vasprintf strndup strsep poll

If you add the gettext module here,
you don't need to check for libintl.h below (in configure.in),
and in place of code like this:

> +#ifdef HAVE_LIBINTL_H
> +#include <libintl.h>
> +#endif

you can #include "gettext.h" unconditionally.
That in turn saves you from having to add the #ifdefs here:

> +#ifdef HAVE_LIBINTL_H
>      if (!bindtextdomain(GETTEXT_PACKAGE, LOCALEBASEDIR))
>          return (-1);
> +#endif

since bindtextdomain is defined away when it's not available.

>  rm -f				\
>      .gitignore			\
> Index: configure.in
> ===================================================================
> RCS file: /data/cvs/libvirt/configure.in,v
> retrieving revision 1.109
> diff -u -r1.109 configure.in
> --- configure.in	6 Dec 2007 10:24:52 -0000	1.109
> +++ configure.in	6 Dec 2007 11:27:48 -0000
...
> -AC_CHECK_HEADERS([paths.h sys/syslimits.h])
> +AC_CHECK_HEADERS(libintl.h pwd.h paths.h sys/syslimits.h sys/utsname.h sys/wait.h winsock.h)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]