[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] 2/22 Extra function and header checks



"Richard W.M. Jones" <rjones redhat com> wrote:
> Changes configure to test for extra functions and headers which are
> missing on Windows.
...
> Index: configure.in
> ===================================================================
> RCS file: /data/cvs/libvirt/configure.in,v
> retrieving revision 1.111
> diff -u -r1.111 configure.in
> --- configure.in	6 Dec 2007 16:34:48 -0000	1.111
> +++ configure.in	7 Dec 2007 10:38:49 -0000
> @@ -60,10 +60,10 @@
>  LIBVIRT_COMPILE_WARNINGS(maximum)
>
>  dnl Availability of various common functions (non-fatal if missing).
> -AC_CHECK_FUNCS([regexec cfmakeraw])
> +AC_CHECK_FUNCS([cfmakeraw regexec uname])
>
>  dnl Availability of various common headers (non-fatal if missing).
> -AC_CHECK_HEADERS([paths.h sys/syslimits.h])
> +AC_CHECK_HEADERS(pwd.h paths.h sys/syslimits.h sys/utsname.h sys/wait.h winsock2.h)

Not a big deal, but it's a little better not to remove those quotes ([]).
The risk is really minimal (who's going to define an m4 macro named
sys, pwd, paths, etc?) but good practice.

There's plenty of "underquoting" in just about any configure.in
script you care to look at.

+1 on patches 1..6


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]