[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Always build in python/ subdir.



On Mon, Dec 10, 2007 at 06:16:33PM +0100, Jim Meyering wrote:
> Hi guys,
> 
> I'd like to remove the PYTHON_SUBDIR parameter, but (of course)
> still allow configure/build to proceed even when python-devel is
> not installed.
> 
> Why?
> Because with the current code, I was able to build and _try_ to test
> a broken distribution tarball.
> 
> Here's how it happened:
> 
>     While I had temporarily removed python-devel, I configured/built
>     libvirt, ran "make check" to ensure that everything was ok, created a
>     tarball to test on a remote RHEL5 system, and copied it over.  But on
>     the RHEL5 system, configure failed due to lack of python/Makefile.in.
>     The entire python/ directory was missing.
> 
> With the following change, I've confirmed it works as well as before
> (on both rawhide and RHEL5), yet can't cause the trouble I described:
> 
> 	Always build in python/ subdir.
> 	* configure.in (PYTHON_SUBDIR): Don't set.  Remove all uses.
> 	* Makefile.am (SUBDIRS): Hard-code "python" here.
> 	(tests): Test equivalent "$(pythondir)", not @PYTHON_SUBDIR  

  Okay, I understand the problem and the fix looks right to me, +1

   thanks !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]