[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Fix detach-disk command for tap device



On Fri, Dec 14, 2007 at 02:32:53PM +0000, Daniel P. Berrange wrote:
> On Fri, Dec 14, 2007 at 10:21:54AM +0000, Richard W.M. Jones wrote:
> > Saori Fukuta wrote:
> > >The detach-disk command does not work for tap device, since
> > >xenStoreDomainGetDiskID is always searching for vbd device from
> > >XenStore. c.f. This is a the related patch:
> > >http://git.et.redhat.com/?p=libvirt.git;a=commit;h=d27506d3a36e12b977f6a896bae5082134db8fb5
> > >
> > >So, I changed the searching path to both vbd and tap.
> > 
> > +1 from me.  If no one else objects I'll commit it next week.
> 
> ACK, no problem. I really wish I had paid more attention when tap went
> upstream so XenD didn't have this insanity :-(

  Commited, thanks !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]