[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Enhance virBuffer code



On Thu, Dec 13, 2007 at 06:27:18PM +0000, Richard W.M. Jones wrote:
> Richard W.M. Jones wrote:
> >(eg. virBufferEscapeString [...]
> 
> Erm, that should be 'cf' not 'eg'.

The remote driver in CVS doesn't work with this patch applied - it just
refuses the connection everytime. It looks like a conditional got 
reversed - see attached patch

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 
Index: remote_internal.c
===================================================================
RCS file: /data/cvs/libvirt/src/remote_internal.c,v
retrieving revision 1.48
diff -u -p -r1.48 remote_internal.c
--- remote_internal.c	17 Dec 2007 10:07:56 -0000	1.48
+++ remote_internal.c	17 Dec 2007 17:04:08 -0000
@@ -455,7 +455,7 @@ doRemoteOpen (virConnectPtr conn,
 #else
          uri->query =
 #endif
-         qparam_get_query (vars)) != 0) goto failed;
+         qparam_get_query (vars)) == NULL) goto failed;
 
     free_qparam_set (vars);
 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]