[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH]Report the error from xend for Domain-0



On Tue, Feb 27, 2007 at 01:47:29PM +0000, Daniel P. Berrange wrote:
> On Tue, Feb 27, 2007 at 07:34:01PM +0900, Kazuki?$B!!Mizushima wrote:
> > When I test virsh subcommands, dump save, for Domain-0,
> > It says following normal messages, but the processing is not done.
> > 
> > -    } else if ((ret = 202) && (strstr(content, "failed") != NULL)) {
> > +    } else if ((ret == 202) && (strstr(content, "failed") != NULL)) {
> 
> Yikes - that's a good catch - compiler wasn't even complaining because it
> was surrounded in brackets. I'll apply this fix shortly.

I made one small change to your patch when committing it. It had been using
'strcasestr(content, "cannot"), but the strcasestr function is a GNU-ism
so I replaced it with 'strstr(content, "Cannot")'.

Regards,
Dan. 
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]