[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH]Report the error from xend for Domain-0



Daniel P. Berrange wrote:
On Tue, Feb 27, 2007 at 07:34:01PM +0900, Kazuki?$B!!Mizushima wrote:
When I test virsh subcommands, dump save, for Domain-0,
It says following normal messages, but the processing is not done.

-    } else if ((ret = 202) && (strstr(content, "failed") != NULL)) {
+    } else if ((ret == 202) && (strstr(content, "failed") != NULL)) {

Yikes - that's a good catch - compiler wasn't even complaining because it
was surrounded in brackets. I'll apply this fix shortly.

Yes, that's a good reason NOT to bracket tests.

Rich.

--
Emerging Technologies, Red Hat  http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF     Mobile: +44 7866 314 421
 "[Negative numbers] darken the very whole doctrines of the equations
 and make dark of the things which are in their nature excessively
 obvious and simple" (Francis Maseres FRS, mathematician, 1759)

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]