[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Patch: driver->open functions return declined or error status



On Wed, Feb 28, 2007 at 04:18:45PM +0000, Richard W.M. Jones wrote:
> 
> I want to change the driver->open function so that as well as declining 
> a name (returning -1 as now), it may also indicate that it accepts the 
> name, but there is an error opening the name (-2).  virConnectOpen fails 
> in this second case, rather than going on and trying the next driver in 
> sequence.

This is all sane - I've certainly seen some really odd problems before
from not being able to detect the difference between an operation not
being supported, vs supported but failed. When we merge the Xen drivers
into one those will go away, and thus addresses the open() case, so 
I'll commit it unless anyone objects.

Regards,
Dan
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]