[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Virtual networking



On Mon, 2007-01-22 at 21:20 +0000, Daniel P. Berrange wrote:
> On Mon, Jan 22, 2007 at 02:46:11PM +0000, Mark McLoughlin wrote:
> > # Dan's patches
> > http://www.gnome.org/~markmc/code/libvirt-networking/libvirt-qemu-daemon.patch
> > http://www.gnome.org/~markmc/code/libvirt-networking/libvirt-qemu-driver.patch
> 
> Now updated at:
> 
> http://people.redhat.com/berrange/libvirt/libvirt-qemu-daemon-2.patch
> http://people.redhat.com/berrange/libvirt/libvirt-qemu-driver-2.patch

	Okay, I've updated my patch set to use them:

  http://www.gnome.org/~markmc/code/libvirt-networking/

	One bug I found was that libvirt fails to connect if you don't have TLS
certs, even if the server doesn't request TLS. See attached patch.

> > http://www.gnome.org/~markmc/code/libvirt-networking/libvirt-qemu-no-c99.patch
> 
> I simply removed -std=c99 and fixed up places I'd used C99 constructs, so should
> no longer be needed

	_XOPEN_SOURCE and _POSIX_C_SOURCE disable _SVID_SOURCE, so I still need
to enable that for struct ifreq and friends.

Thanks,
Mark.
Index: libvirt-danpb/src/qemud_internal.c
===================================================================
--- libvirt-danpb.orig/src/qemud_internal.c
+++ libvirt-danpb/src/qemud_internal.c
@@ -623,6 +623,8 @@ static int qemudClientInitialize(virConn
     }
 
     if (tls) {
+        if (qemudTLSInitialize() < 0)
+            return -1;
         printf("TLS accepted, starting handshake\n");
         if (gnutls_init(&conn->session, GNUTLS_CLIENT) < 0)
             return -1;
@@ -725,9 +727,6 @@ int qemudOpen(virConnectPtr conn,
         return -1;
     }
 
-    if (qemudTLSInitialize() < 0) {
-        return -1;
-    }
     conn->handle = -1;
     qemudOpenConnection(conn, uri, flags & VIR_DRV_OPEN_RO ? 1 : 0);
     xmlFreeURI(uri);

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]