[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Virtual networking



On Tue, Jan 23, 2007 at 12:35:09PM +0000, Mark McLoughlin wrote:
> 	Note, a lot of the code in the networking patches is just copied and
> pasted from elsewhere in libvirt, so I'll fix up the original code
> first.

We do have test cases for some of the virsh commands, so I'm going to 
check to see why these leaks were not picked up by valgrind - we have
a special 'make valgrind' target in the tests directoy which runs all
the test suites under the valgrind leak checker.

> On Tue, 2007-01-23 at 11:20 +0100, Karel Zak wrote:
> 
> > +    {"file", VSH_OT_DATA, VSH_OFLAG_REQ, gettext_noop("file containing an XML network description")},
> > 
> >  Cannot we use something like _N() rather than gettext_noop() ?
> 
> 	That's one for Dan ... I suspect it's just because gettext_noop()
> worked with xgettext, whereas _N() didn't. We'd need to pass
> --keyword=_N to xgettext.

Yes, that's exactly the reason - gettext_noop() is automatically understood
by xgettext, and since there's not really many places we use it I didn't
feel need to #define a shorter variant.

Regards, 
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]