[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] #2: Fix remote so that EPIPE errors are caught and reported



On Tue, Jul 03, 2007 at 04:12:56PM +0100, Richard W.M. Jones wrote:
> Here we just fix the remote driver so that if the server goes down, the
> process doesn't die on SIGPIPE.

This isn't thread safe. Changing signals with sigaction affects the
entire process - so if you've got multiple threads running with
multiple  remote connections open, you can get overlapping calls.
Either we should just block sigpipe in virInitialize, or mandate
that the application needs to block sigpipe itself. I'm not sure
really what best course is - I'd probably lean towards saying it is
the application's responsibility to deal with sig handlers.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]