[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Readd buffer errors & some cleanups

Daniel Veillard wrote:
On Tue, Jul 03, 2007 at 11:47:20AM +0100, Richard W.M. Jones wrote:
This readds some error checking of the returns from virBuffer*
functions, removes need for is_blank (a _GNU_SOURCE extension), and a couple of other very minor cleanups.

  Looks fine to me, I just wonder about:

-    while (p && *p && isblank((unsigned char) *p))
+    while (p && *p && (*p == ' ' || *p == '\t'))

I don't think we have support for multiline commands so this should
be fine, but '\n' and '\r' could be tested too.

  in any case +1

isblank is defined as "a space or a tab" [from the man page], hence the substitution above.

I'll apply the patch.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]