[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Proposal: Python bindings should turn NO_DOMAIN/NO_NETWORK errors in KeyError exceptions

Daniel Veillard wrote:
On Wed, Jul 04, 2007 at 10:44:29AM +0100, Richard W.M. Jones wrote:
I propose that we should change the Python bindings so that when the virterror errors VIR_ERR_NO_DOMAIN and VIR_ERR_NO_NETWORK occur in the lookup* functions only, should cause KeyError to be raised.

According to:


"[KeyError is] raised when a mapping (dictionary) key is not found in the set of existing keys."

I've already changed the OCaml bindings so that these errors get converted into Not_found exception, which is the "natural" exception for when something is looked up and not found.

I think this makes sense, I just wonder a bit about the impact on existing client code,

Yes, I have asked Hugh to comment, but it's Independence Day over there so don't expect anything before tomorrow.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]