[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Fix callers to virGetDomain and virGetNetwork



On Wed, Jul 04, 2007 at 11:31:07AM +0100, Richard W.M. Jones wrote:
> (1) Removes virGetDomainByID.  This function was neither used nor exported.
> 
> (2) virGetDomain sets a virterror connection error whenever anything bad 
> happens (realistically malloc failure is the only thing that can go 
> wrong).  Therefore callers do not need to set virterror if the function 
> returns NULL.  The patch fixes these callers.
> 
> (3) Same as (2), for virGetNetwork.

  Looks fine to me, +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]