[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] LSBization of libvirt init script

Daniel Veillard wrote:
  Small patch applied to qemud/libvirtd.init.in:
    - adds an LSB compliant header
    - add a couple of LSB defined functions
    - fixes the name in the chkconfig comments

  Hopefully it's correct :-)

For reference, here are the Fedora guidelines too (they draw upon the LSB ones): http://fedoraproject.org/wiki/FCNewInit/Initscripts

Yup, +1, looks good to me.

Do those standard functions deal with the multiplicity of error codes?

When you commit this, do you think you could also add a line into qemud/.cvsignore to get it to ignore the generated file libvirtd.init (or else, I suppose, commit this generated file)?


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]