[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] XML escaping patch



Daniel P. Berrange wrote:
So instead of that we could do

    dom =  xmlRootElement("domain")
    xmlAttributeInt(dom, "id", id);
    xmlAttributeString(dom, "type", "xen");

    os = xmlElement(dom, "os")
    xmlElementString(os, "bootloader", tmp)
char *doc = xmlString(dom);
    xmlFree(dom);
    return doc;

Even better might be to use a templating library to load external XML docs containing placeholders which can be substituted. But I think it's a waste of time to worry about this too much when Daniel [Veillard]'s patch solves the immediate bugzilla.

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]