[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Add the check of the format of MAC address on virsh attach-interface



On Fri, Jul 13, 2007 at 02:24:01PM +0900, Masayuki Sunou wrote:
> Hi
> 
> Even if specified MAC address is invalid,
> network interface is attached to the guest.
> And attached network interface cannot communicate. 
> 
> This patch checks the format of MAC address,
> and virsh become error when it is invalid.
> 
> Signed-off-by: Masayuki Sunou <fj1826dm aa jp fujitsu com>

  Hum, right, I don't expect to see non-ethernet MAC addresses at
that point, and doing the checking earlier allows a better handling
of the error. This makes sense so applied, but I fixed the code to avoid
a couple of warnings from gcc.

  thanks !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]