[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Add the check of the format of MAC address on virsh attach-interface



On Fri, Jul 13, 2007 at 02:24:01PM +0900, Masayuki Sunou wrote:
> Hi
> 
> Even if specified MAC address is invalid,
> network interface is attached to the guest.
> And attached network interface cannot communicate. 
> 
> This patch checks the format of MAC address,
> and virsh become error when it is invalid.

It looks reasonable, but if we're going todo this, we should do it
everywhere, not just in Xen's attach code - we, we should have
a file mac.c  for validating mac addresses & call if from the Xen,
QEMU and Test drivers at all neccesssary places.

I think in general now that we've got all drivers using the internal
driver API, we need to make sure when we code these kind of fixes we
make sure as much code can be shared between drivers as possible.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]