[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Fix accident close of monitor FD & leak of logfile FD to child



On Thu, Jul 19, 2007 at 01:52:00AM +0100, Daniel P. Berrange wrote:
> After the QEMU monitor filehandle has been successfully initialized, we
> then promptly close it ! It seems a 'return' statement accidentally got
> removed somewhere during previously refactoring.
> 
> Second, the QEMU logfile does not have the close-on-exec flag set so the
> logfile is leaked to child processes.
  +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]