[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler



On Fri, Jul 20, 2007 at 07:10:12PM +0900, Saori Fukuta wrote:
> >   That would be nicer, we have the information and don't pass it to the user.
> > It may not be a big gain when used purely from virsh but for future automatic
> > tuning tools it may be interesting to get the value reported back. An
> > snprintf to a local buffer to generate the string may be sufficient. I 
> > didn't applied remove_perD.patch for this reason, if you send another
> > patch I will fix this or I could just do it.
> 
> OK, I understand the purpose of passing it.
> I simply added snprintf. How about this ?
> 
> # ./virsh schedinfo 25 --weight 0
> libvir: Xen error : invalid argument in xenHypervisorSetSchedulerParameters: 
> Credit scheduler weight parameter (0) is out of range (1-65535)
> 
> # ./virsh schedinfo 25 --cap  -1
> libvir: Xen error : invalid argument in xenHypervisorSetSchedulerParameters: 
> Credit scheduler cap parameter (-1) is out of range (0-65535)

  Great, applied and commited,

    thanks !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]