[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Make QEMU driver honour 'listen' flag for VNC



On Mon, Jul 23, 2007 at 08:51:36PM +0100, Daniel P. Berrange wrote:
> On Mon, Jul 23, 2007 at 07:06:25PM +0100, Daniel P. Berrange wrote:
> > In QEMU 0.9.0 or later it is possible to tell QEMU to only listen on a
> > particular IP address. THis patch adapts the code so that it honours the
> > 'listen' attribute on the <graphics> tag if using QEMU >= 0.9.0. It also
> > re-enables the tests for this capability that I temporarily disabled.
> 
> There was a further complication of this. It turns out our handling of
> headless VMs was broken -ie, VMs without any <graphics> tag all. We
> specify -nographic on the command line. Unfortunately when you do this,
> QEMU splatters any settings for monitor, serial or parallel device you
> gave on the command line before the -nographic flag. Unfortunately again
> we order  -monitor pty before -nographic, so we fail to get a monitor
> console setup correctly.  This updated patch extends the previous so
> that we have -nographic before all other args it might affect.

  Hum, a program whose behaviour depends on the order of the flags,
is taht really intended upstream ?

[...]
> +    /*
> +     * NB, -nographic *MUST* come before any serial, or monitor
> +     * or parallel port flags due to QEMU craziness, where it
> +     * decides to change the serial port & monitor to be on stdout
> +     * if you ask for nographic. So we have to make sure we override
> +     * these stupid defaults ourselves
> +     */

 let's remove the s word, it's sure annoying but no need to bury the feeling
in the code :-)

  +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]