[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] add a ttyconsole command



Daniel Veillard wrote:
 It was pointed out that we have a vncdisplay command but none for
extracting the TTY console device:

  https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239687

the trivial associated patch adds it as well as the doc in the man page

I wonder if it should print some error message if the <console> node doesn't exist? I tried your patch on a FV domain, before remembering that FV domains don't have consoles, and it prints an empty line (but the return code is 1, which is good):

$ src/.libs/virsh ttyconsole debian32fv

$ echo $?
1

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]