[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] return 0 networks if Network driver not implemented



On 6/14/07, Daniel P. Berrange <berrange redhat com> wrote:
On Thu, Jun 14, 2007 at 04:23:38PM -0400, Mark Johnson wrote:
> This handles net-list, etc. a little more gracefully for Xen.

I'm not so sure about this one.

 a. Xen does have support for net-list which is currently done via the
    (badly named) libvirt_qemud daemon. Though the network stuff would
    certainly require porting to Solaris for the bridge.c and the
    iptables.c  files at the very least.

We would probably have to write an separate implementation.
We use virtual NICs instead of a bridge and have a different
firewall/NAT.


 b. If the network driver isn't available - as with many other of the
    APIs - its standard practice for us to return a not implemented
    error. I think its important to keep this distinction between
    implemented, but no networks defined, vs  not implemented at all.

What end-application scenario were trying to address with these change ?

I know virt-manager will complain once a second about the network functions
if they return not implemented. This is on my list of things to fix in
virt-manager though - once its tried once & found networking is unavailable
it should stop trying & thus stop spewing warning messages after the first
one.

That's it. :-)  It's was temporary fix until we could implement the network
functionality. Fixing virt-manager is better..  Please drop this patch,

Thanks,

Mark



Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]