[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] header file changes for Solaris



On Thu, Jun 14, 2007 at 07:05:49PM -0400, Mark Johnson wrote:
> On 6/14/07, Daniel P. Berrange <berrange redhat com> wrote:
> >On Thu, Jun 14, 2007 at 05:26:39PM -0400, Mark Johnson wrote:
> >> This patch has the includes need to build on Solaris.
> >> I've been using ifdef linux & ifndef linux to distinguish
> >> between solaris and linux at this point.
> >
> >Looks ok aside from
> >
> >> +#ifndef __linux__
> >> +#define        NAME_MAX        14
> >> +#endif
> >
> >The #ifndef should test against NAME_MAX itself, rather than __linux__
> >
> >Also, NAME_MAX is intended to be the maximum length of an unqualified
> >filename, so 14 characters is rather too small. 255 is what Linux has
> >it defined as, so I'd go for that unless Solaris has a different named
> >constant for  maximum filename length ?  I know BSD uses MAXNAMLEN,
> >but NAME_MAX is POSIX
> 
> Yep, I agree with both...  Do yo want me to re-submit the patch
> or do you want to make those changes?

No need - its quick enough to change this when its applied to CVS.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]