[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Do check the UUID in __virGetDomain()



Hi Dan

> Hmm, I strongly suspect one (or more) of the commands in this series
> of steps is missing a call for virDomainFree().  Every individual
> virsh command should be freeing all the objects it has open (aside
> fromthe virConnectPtr), so the cache of virDomainPtr objects ought
> to be empty for every individual command.
> 
I think that it is not bad to have cache to make performance better. 
But I think that it is necessary to control it correctly. 

> The UUID chcek is still sensible, but we need to find which virsh 
> command is not freeing objects too.
> 
I think that we should remove the missing of freeing the object one by one.


Thanks,
Masayuki Sunou

In message <20070607111427 GA12398 redhat com>
   "Re: [Libvir] [PATCH] Do check the UUID in __virGetDomain()"
   ""Daniel P. Berrange" <berrange redhat com>" wrote:

> On Thu, Jun 07, 2007 at 03:03:11PM +0900, Masayuki Sunou wrote:
> > Hi
> > 
> > This patch adds checking the UUID in __virGetDomain().
> > 
> > Now, the UUID of domain is wrong in the following operations.
> > 
> > 1. Start virsh in interactive mode.
> > 2. Execute domuuid to the domain
> > 3. Execute undefine to the domain which executed domuuid in 2.
> > 4. Create the domain whose name is same as the domain that executed undefine.
> > 5. Execute domuuid for the new domain
> 
> Hmm, I strongly suspect one (or more) of the commands in this series
> of steps is missing a call for virDomainFree().  Every individual
> virsh command should be freeing all the objects it has open (aside
> fromthe virConnectPtr), so the cache of virDomainPtr objects ought
> to be empty for every individual command.
> 
> The UUID chcek is still sensible, but we need to find which virsh 
> command is not freeing objects too.
> 
> Dan.
> -- 
> |=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
> |=-           Perl modules: http://search.cpan.org/~danberr/              -=|
> |=-               Projects: http://freshmeat.net/~danielpb/               -=|
> |=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]