[Libvir] [PATCH] header file changes for Solaris

[Richard W.M. Jones]

Daniel P. Berrange wrote:
> On Thu, Jun 14, 2007 at 05:26:39PM -0400, Mark Johnson wrote:
>> This patch has the includes need to build on Solaris.
>> I've been using ifdef linux & ifndef linux to distinguish
>> between solaris and linux at this point.
> 
> Looks ok aside from
[..]

No, I don't agree.  We should use configure.in to test for the presence 
of header files and then do things like:

#ifdef HAVE_STRINGS_H
#include <strings.h>
#endif

See the current configure.in, AC_CHECK_HEADERS.

In fact we already have the HAVE_STRINGS_H symbol defined.

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20070615/d32ddc0c/attachment-0001.bin>