[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Solaris dom0 support



On Fri, Jun 15, 2007 at 05:57:30AM -0400, Daniel Veillard wrote:

> >  #include <xen/xen.h>
> > +#ifdef __linux__
> >  #include <xen/linux/privcmd.h>
> > +#else
> > +#include <xen/sys/privcmd.h>
> > +#endif
>  
>  In general I would prefer Solaris sections to not be defined as !linux
> but as a positive test on your platform macro, but in that case since it's
> a Xen path it's fine

I recently putback a change to install in xen/sys/* on Linux too. I
think this will need to be a configure test at some point, to support
older Xens. That is:

older Xen on Linux: linux/privcmd.h
newer Xen on Linux: sys/privcmd.h
Xen on Solaris: sys/privcmd.h

>   makes sense, so you changed the hypervisor to copy or pin the user data ?

Actually the dom0 kernel does this.

> > +void
> > +loadCapabilities(FILE *cpuinfo, FILE *capabilities, char *hvm_type,
> > +    int *host_pae, char *line, int LINE_SIZE)
> > +{
> > +    struct {
> > +        uint32_t r_eax, r_ebx, r_ecx, r_edx;
> > +    } _r, *rp = &_r;
> > +    int d, cmd;
> > +    char *s;
> > +    hypercall_t hc;
> 
>   So that's arch dependant right ? Could you 

In terms of cpuid, it works on Linux too, except that Linux has
/dev/cpu/0/cpuid and we have /dev/cpu/self/cpuid. Also I don't think you
can rely on the Linux driver being available.

regards
john


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]