[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] header file changes for Solaris



On Fri, Jun 15, 2007 at 09:32:13AM -0400, Mark Johnson wrote:
> As johnlev said, I can fix the limits_iso.h with limits.h
> 
> 
> ><string.h> is in ISO C, but <strings.h> is not.  So as Daniel Veillard
> >said you can include the former without checks, but the latter should be
> >defended with an #ifdef HAVE_STRINGS_H.
> >
> >On BSD, <strings.h> has the legacy functions like bcopy and index.  Are
> >we using those?  Shouldn't we instead replace any instances with memcpy
> >/ memmove / strchr / strrchr?
> 
> It's needed because of index().

  please use strchr() let's get rid of strings.h , that will be way simpler.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]