[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] setmem checks



Mark Johnson wrote:
On 6/15/07, Daniel P. Berrange <berrange redhat com> wrote:
On Fri, Jun 15, 2007 at 11:30:02AM -0400, Mark Johnson wrote:
> Which of these does folks prefer (same would apply to SetMaxMem).

I prefer the first. Full error checking & reporting. GetInfo should
never fail under any reasonable scenario. If it does fail its very
unlikely that a SetMemory would then work, so its pointless continuing


update patch attached.

+1

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]