[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Device attach/detach on virsh (command optionversion)



Hi

Would you give me a comment on this patch?

Thanks,
Masayuki Sunou.

In message <200705291541 BEI87583 29KNGE37 aa jp fujitsu com>
   "[Libvir] [PATCH] Device attach/detach on virsh (command optionversion)"
   "Masayuki Sunou <fj1826dm aa jp fujitsu com>" wrote:

> Hi
> 
> This patch adds virsh attach-device/detach-device.
> This supports a definition of a device by command option(proposal 1).
> 
> I examine the following opinions, and "attach-interface" supports only two
> common case (bridge, virtual network). 
> 
> > Networking is more complicated because there are 8 (!) different ways to
> > connected up VMs so far. We could either have huge numbers of args, or
> > we could just support the two common cases (bridge, virtual network) and
> > say for more complex cases use full XML.
> 
> 
> Any comments are welcome!
> 
> Signed-off-by: Masayuki Sunou <fj1826dm aa jp fujitsu com>
> 
> Thanks,
> Masayuki Sunou.
> 
> 
> In message <200705111842 IJH95853 739E2KNG aa jp fujitsu com>
>    "Re: [Libvir] [RFC] Device attach/detach on virsh"
>    "Masayuki Sunou <fj1826dm aa jp fujitsu com>" wrote:
> 
> > Hi
> > 
> > I understood as follows.
> > 
> > * There is no problem in a proposal 1 and a proposal 2
> > * It is better that the user can choose use of XML and use of command-option
> >   by the situation
> > 
> > Therefore, I want to add both proposal 1 and proposal 2 to virsh.
> > There is no problem in this opinion?
> > 
> > And, I am going to correct about naming.
> >  vif --> interface
> >  vbd --> disk
> 
> --
> Libvir-list mailing list
> Libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 
> 
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]