[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH 15/20: remove use of libsysfs in bridge code



The current code for setting up bridges in virtual networks links against
the libsysfs library. This is use to get/set the spanning-tree-protocol and
forward-delay parameters on the bridge device. None of the four methods
using libsysfs are ever called though. The fact that the setters are not
called during network start is a bug. There is no need for getters at all
since we have the config in memory all the time. The libsysfs is also not
exactly an ABI stable library - we're unable to compile libvirt on FC5
for example because of this.  This patch changes the bridge code to just
invoke the brctl command directly which is much more portable & avoids
the need for us to link libvirt.so against libsysfs.so It also fixes the
network creation process to actually set STP & forward-delay parameters
if specified.

 configure.in      |   16 --
 libvirt.spec.in   |    4 
 qemud/Makefile.am |    2 
 qemud/bridge.c    |  298 +++++++++++++++++++++++-------------------------------
 qemud/driver.c    |   16 ++
 5 files changed, 146 insertions(+), 190 deletions(-)


Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]