[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Add support for scheduler functions in remote



Daniel P. Berrange wrote:
On Fri, Jun 22, 2007 at 12:33:59PM +0100, Richard W.M. Jones wrote:
This is a rather tedious patch, but I've tested it against the Xen driver and it works for getting and setting the various parameters and scheduler type.


Looks good to me, except for two calls to strdup which don't report
errors on ENOMEM.

+        args.params.params_val[i].field = strdup (params[i].field);

Alright, I'll fix those two and apply.

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]