[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Do check the UUID in __virGetDomain()



On Fri, Jun 29, 2007 at 05:36:44PM +0900, Masayuki Sunou wrote:
> Hi Rich, Dan
> 
> Thank you for a reviewing and detailed suggestion.
> I understand your suggestion as follows and remake a patch.
>  - The reason that the virDomain object is not cleared is the garbage
>    collector does not work well.
>    And its cause is virsh.c misses the call of virDomainFree().
> 
> This patch fixes virDomainFree() and virNetworkFree() which virsh.c
> misses the call.

  That looks like the right fixes to me, thanks a lot !

> However, I detect the problem that resembles this happens in virt-manager,
> and I can not fix it.
> Therefore I register it to Bugziila.
> 
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246198

  Hum, I remember looking at this a long time ago, we had the same
effect (and IIRC that was because the update of the state change in
xenstored was too slow, so there was a conflict there), but now that
could be something completely different with the same effect.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]