[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Patch: Fix documentation and code of virGetDomain function



On Wed, 2007-02-28 at 16:24 +0000, Richard W.M. Jones wrote:
>  virGetDomain(virConnectPtr conn, const char *name, const unsigned char *uuid) {
>      virDomainPtr ret = NULL;
>  
> -    if ((!VIR_IS_CONNECT(conn)) || ((name == NULL) && (uuid == NULL)) ||
> +    if ((!VIR_IS_CONNECT(conn)) || (name == NULL) || (uuid == NULL) || 

	Need the same fix in virGetNetwork()

	(And DV obviously has a parenthesis fetish ... I don't know what's
wrong with:

    if (!VIR_IS_CONNECT(conn) || !name || !uuid || !conn->hashes->mux)

	:-)

Cheers,
Mark.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]