[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Patch: Driver private data



On Wed, 2007-02-28 at 17:06 +0000, Daniel P. Berrange wrote:
> On Wed, Feb 28, 2007 at 04:27:05PM +0000, Richard W.M. Jones wrote:
> > This patch is more aspirational than currently useful.  Only the remote 
> > patch would use driver->private, but I think others should be changed to 
> > do so too.
> 
> Certainly - I'll update the QEMU & Test drivers at least once we've got 
> this in. The Xen driver can be best addressed when they are merged.

	Cool, be careful with the QEMU driver, though.

	i.e. you can have a situation where one driver is used for domains, and
the QEMU driver is used for networks. Or, indeed, the QEMU driver might
be used for both.

	We probably want a networkPrivate pointer which will also contain the
qemuPrivate data and the driver will always prefer networkPrivate if it
is non-NULL. Something like that.

Cheers,
Mark.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]