[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH]Report the error from xend for Domain-0



On Thu, Mar 01, 2007 at 08:13:40PM +0900, Kazuki Mizushima wrote:
> Hi, Dan
> 
> After I studying this issue, 
> I change my mind about fixing method.
> How do you think about this?
> 
> 1)Change the scanning code from "Cannot" to "xend.err"
> 
> By the survey on xend_internal.c, I found 
> Xend reports errors which surely has "xend.err" term,
> For this reason, I want to change term from "Cannot" to "xend.err".
> 
> N.B.
> When I try to grep xen/xend by "XendError", 
> there are many error strings not catched above term.
> 
> With this fixes, virsh command can report error from Xend 
> about the information of not only Dom0 but also DomX. 
> (except going on next Driver & guarding at xm)  
> 
> 
> 2)String("xend.err") checking in HTTP return code (200) case
> 
> Also when http returns normal Status Code(OK, Created, Accepted),
> I think that now it is better to check the content, because 
> like below it is. 

Yes, this works much bettter that the current impl, so I've committed
it.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]