[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] lots of warnings removed - libvirt can now compile with -Werror



On Mon, Mar 05, 2007 at 09:18:49AM +0000, Mark McLoughlin wrote:
> Hi Rich,
> 	Good stuff, looks fine to commit to me.
> 
> 	Just a nitpick:
> 
> On Fri, 2007-03-02 at 15:00 +0000, Richard W.M. Jones wrote:
> > -            activeNames = vshMalloc(ctl, sizeof(int) * maxactive);
> > +            activeNames = vshMalloc(ctl, sizeof (char *) * maxactive);
>                                                   ^
>  
> > -            qsort(&activeNames[0], maxactive, sizeof(int), namesorter);
> > +            qsort(activeNames, maxactive, sizeof (char *), namesorter); 
>                                                    ^
> 
> 	Extra whitespace here ...

I commited Rich's patch with a handful of whitespace tweaks applied too.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]