[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH][RFC] Add --keymap option to virt-install



Hi, Dan

Thank you for committing a patch.

I confirmed that I can use jp106 keyboard on HVM domain,
and the keymap that is configured in the XML.
when I used latest patch(revision 1.435).

Thanks,
Tomohiro Takahashi.

On Tue, Mar 06, 2007 at 03:21:16PM +0000, Daniel P. Berrange wrote:
On Tue, Mar 06, 2007 at 10:00:08PM +0900, Takahashi Tomohiro wrote:
> I would like to add --keymap option to virt-install in order to set up
> jp106 keymap. Because I can't use jp106 keyboard. So, I made a patch
> (notes:It relates python-virtinst)
>
>  Usage: virt-install --keymap=ja
>
> I confirmed that I can use jp106 keyboard on HVM domain.
> But didn't confirm PV domain.
>
> Please give me an advice, if you have it.

I've been expecting someone to send this patch for quite a while :-)

It all looks good to me, although all my keyboards are US english
so my own testing will be limited to making sure the keymap gets
passed through to the QEMU daemon correctly. For paravirt, I think
you need to have Xen 3.0.5 to use keymap, but I'll double check
that and then apply this.

> @@ -1903,6 +1907,8 @@ virConfPtr xenXMParseXMLToConfig(virConn
>                         len += 11 + strlen((const char*)vnclisten);
>                     if (vncpasswd)
>                         len += 11 + strlen((const char*)vncpasswd);
> +                    if (keymap)
> +                        len += 11 + strlen((const char*)keymap);
>                     if ((val = malloc(len)) != NULL) {
>                         strcpy(val, "type=vnc");
>                         if (vncunused) {

A minor bug - the length is only 8, not 11, but I'll fix that when I
commit, so don't worry about sending an updated patch.

Ok, this is now committed - I also extended the XML generation code so
that it will report back the keymap that is configured in the XML
dump, as well as updating the test suite to check the handling.

Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: .cpan.org/~danberr/ -=| |=- Projects: at.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 505 -=|




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]