[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Patch: Fix documentation and code of virGetDomain function



On Tue, Mar 06, 2007 at 10:06:32PM +0000, Daniel P. Berrange wrote:
> On Thu, Mar 01, 2007 at 09:46:11AM +0000, Mark McLoughlin wrote:
> > On Wed, 2007-02-28 at 16:24 +0000, Richard W.M. Jones wrote:
> > >  virGetDomain(virConnectPtr conn, const char *name, const unsigned char *uuid) {
> > >      virDomainPtr ret = NULL;
> > >  
> > > -    if ((!VIR_IS_CONNECT(conn)) || ((name == NULL) && (uuid == NULL)) ||
> > > +    if ((!VIR_IS_CONNECT(conn)) || (name == NULL) || (uuid == NULL) || 
> > 
> > 	Need the same fix in virGetNetwork()
> 
> Applied Rich's patch to CVS along with the corresponding fix to virGetNetwork

  Changing documented semantic because there is a bug (or rather TODO) doesn't
sound right to me.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]