[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Check calls to printf-like functions (and some fixes)



On Mon, Mar 12, 2007 at 05:47:10PM +0000, Richard W.M. Jones wrote:
> Daniel P. Berrange wrote:
> >Which would then turn into
> >
> >   if (foo)
> >      ;
> >
> >Which causes GCC to complain with
> >
> >  cc1: warnings being treated as errors
> >  driver.c: In function â??qemudMonitorCommandâ??:
> >  driver.c:101: warning: empty body in an if-statement
> >
> >If you have empty  do{}while(0)   then gcc won't complain.
> >
> >So all we need do is drop the extra ';' from the #define for qemudDebug,
> >but keep the empty loop
> 
> Ah ... what a stupid warning!
> 
> Yes agreed in that case.  Can we apply with your modification then?

Sure, that works for me.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]